pgsql: Avoid platform-dependent infinite loop in pg_dump. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid platform-dependent infinite loop in pg_dump.
Date
Msg-id E1RObt0-0000IU-AL@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid platform-dependent infinite loop in pg_dump.

If malloc(0) returns NULL, the binary search in findSecLabels() will
probably go into an infinite loop when there are no security labels,
because NULL-1 is greater than NULL after wraparound.

(We've seen this pathology before ... I wonder whether there's a way to
detect the class of bugs automatically?)

Diagnosis and patch by Steve Singer, cosmetic adjustments by me

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cf22e851b6ae8737f3e767dffcadf1722fbb36a7

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |   11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix server header file installation with vpath builds
Next
From: Robert Haas
Date:
Subject: pgsql: Revert removal of trace_userlocks, because userlocks aren't gone