pgsql: Don't mark auto-generated types as extension members. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Don't mark auto-generated types as extension members.
Date
Msg-id E1RE7V4-0006Um-So@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't mark auto-generated types as extension members.

Relation rowtypes and automatically-generated array types do not need to
have their own extension membership dependency entries.  If we create such
then it becomes more difficult to remove items from an extension, and it's
also harder for an extension upgrade script to make sure it duplicates the
dependencies created by the extension's regular installation script.

I changed the code in such a way that this happened in commit
988cccc620dd8c16d77f88ede167b22056176324, I think because of worries about
the shell-type-replacement case; but that cure was worse than the disease.
It would only matter if one extension created a shell type that was
replaced with an auto-generated type in another extension, which seems
pretty far-fetched.  Better to make this work unsurprisingly in normal
cases.

Report and patch by Robert Haas, comment adjustments by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7b96519fe24b6a675b2cd39ed3b89302b8f1fedb

Modified Files
--------------
src/backend/catalog/pg_type.c |   14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Don't mark auto-generated types as extension members.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Document how to accent Alvaro Herrera in the release notes.