pgsql: Replace hardcoded switch in object_exists() with a lookup table. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Replace hardcoded switch in object_exists() with a lookup table.
Date
Msg-id E1RDcJb-0002Rx-5Q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Replace hardcoded switch in object_exists() with a lookup table.

There's no particular advantage to this change on its face; indeed,
it's possible that this might be slightly slower than the old way.
But it makes this information more easily accessible to other
functions, and therefore paves the way for future code consolidation.
Performance isn't critical here, so there's no need to be smart about
how we do the search.

This is a heavily cut-down version of a patch from KaiGai Kohei,
with several fixes by me.  Additional review from Dimitri Fontaine.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fa351d5a0db0672b6f586315720302e493116f27

Modified Files
--------------
src/backend/catalog/objectaddress.c |  257 ++++++++++++++++++++++------------
1 files changed, 166 insertions(+), 91 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Repair breakage in VirtualXactLock.
Next
From: Tom Lane
Date:
Subject: pgsql: Rearrange the implementation of index-only scans.