pgsql: Fix index matching for operators with mixed collatable/noncollat - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix index matching for operators with mixed collatable/noncollat
Date
Msg-id E1R98Ua-0002OI-CP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix index matching for operators with mixed collatable/noncollatable inputs.

If an indexable operator for a non-collatable indexed datatype has a
collatable right-hand input type, any OpExpr for it will be marked with a
nonzero inputcollid (since having one collatable input is sufficient to
make that happen).  However, an index on a non-collatable column certainly
doesn't have any collation.  This caused us to fail to match such operators
to their indexes, because indxpath.c required an exact match of index
collation and clause collation.  It seems correct to allow a match when the
index is collation-less regardless of the clause's inputcollid: an operator
with both noncollatable and collatable inputs could perhaps depend on the
collation of the collatable input, but it could hardly expect the index for
the noncollatable input to have that same collation.

Per bug #6232 from Pierre Ducroquet.  His example is specifically about
"hstore ? text" but the problem seems quite generic.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/0c2c2495ad485ce5a94cdd1ace92721933392fe7

Modified Files
--------------
src/backend/optimizer/path/indxpath.c |   25 ++++++++++++++++++-------
1 files changed, 18 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix index matching for operators with mixed collatable/noncollat
Next
From: Bruce Momjian
Date:
Subject: pgsql: Fix pg_upgrade for EXEC_BACKEND builds (e.g. Windows) by properl