pgsql: gistendscan() forgot to free so->giststate. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: gistendscan() forgot to free so->giststate.
Date
Msg-id E1R4TnO-0003Ug-GK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
gistendscan() forgot to free so->giststate.

This oversight led to a massive memory leak --- upwards of 10KB per tuple
--- during creation-time verification of an exclusion constraint based on a
GIST index.  In most other scenarios it'd just be a leak of 10KB that would
be recovered at end of query, so not too significant; though perhaps the
leak would be noticeable in a situation where a GIST index was being used
in a nestloop inner indexscan.  In any case, it's a real leak of long
standing, so patch all supported branches.  Per report from Harald Fuchs.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/0bbbf592153c31ac5e095db2956e947c15c8435b

Modified Files
--------------
src/backend/access/gist/gistscan.c |    5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: gistendscan() forgot to free so->giststate.
Next
From: Tom Lane
Date:
Subject: pgsql: gistendscan() forgot to free so->giststate.