pgsql: Make CREATE EXTENSION check schema creation permissions. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make CREATE EXTENSION check schema creation permissions.
Date
Msg-id E1Qw2bC-0005nA-0N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make CREATE EXTENSION check schema creation permissions.

When creating a new schema for a non-relocatable extension, we neglected
to check whether the calling user has permission to create schemas.
That didn't matter in the original coding, since we had already checked
superuserness, but in the new dispensation where users need not be
superusers, we should check it.  Use CreateSchemaCommand() rather than
calling NamespaceCreate() directly, so that we also enforce the rules
about reserved schema names.

Per complaint from KaiGai Kohei, though this isn't the same as his patch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d4aa491493e6cfa7542d16deba4018c2fd7af9fd

Modified Files
--------------
src/backend/commands/extension.c |   16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix overoptimistic assumptions in column width estimation for su
Next
From: Tom Lane
Date:
Subject: pgsql: Fix multiple bugs in extension dropping.