pgsql: Remove wal_sender_delay GUC, because it's no longer useful. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove wal_sender_delay GUC, because it's no longer useful.
Date
Msg-id E1QrHc8-0000Ls-NQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove wal_sender_delay GUC, because it's no longer useful.

The latch infrastructure is now capable of detecting all cases where the
walsender loop needs to wake up, so there is no reason to have an arbitrary
timeout.

Also, modify the walsender loop logic to follow the standard pattern of
ResetLatch, test for work to do, WaitLatch.  The previous coding was both
hard to follow and buggy: it would sometimes busy-loop despite having
nothing available to do, eg between receipt of a signal and the next time
it was caught up with new WAL, and it also had interesting choices like
deciding to update to WALSNDSTATE_STREAMING on the strength of information
known to be obsolete.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cff75130b5f63e45423c2ed90d6f2e84c21ef840

Modified Files
--------------
doc/src/sgml/config.sgml                      |   23 ----
src/backend/replication/walsender.c           |  138 +++++++++++++------------
src/backend/utils/misc/guc.c                  |   11 --
src/backend/utils/misc/postgresql.conf.sample |    1 -
src/include/replication/walsender.h           |    1 -
5 files changed, 70 insertions(+), 104 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add a bit of debug logging to backend_read_statsfile().
Next
From: Robert Haas
Date:
Subject: pgsql: Change psql's \dd command to do something more useful.