pgsql: Improve libpq's error reporting for SSL failures. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve libpq's error reporting for SSL failures.
Date
Msg-id E1Ql5JC-0007bx-JD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve libpq's error reporting for SSL failures.

In many cases, pqsecure_read/pqsecure_write set up useful error messages,
which were then overwritten with useless ones by their callers.  Fix this
by defining the responsibility to set an error message to be entirely that
of the lower-level function when using SSL.

Back-patch to 8.3; the code is too different in 8.2 to be worth the
trouble.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/77e4fd5c4a500a4e6b24076c83bee17f55690831

Modified Files
--------------
src/interfaces/libpq/fe-misc.c   |   24 ++++++++++----
src/interfaces/libpq/fe-secure.c |   61 +++++++++++++++++++++++++++++++-------
2 files changed, 67 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Use OpenSSL's SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER flag.
Next
From: Tom Lane
Date:
Subject: pgsql: Improve libpq's error reporting for SSL failures.