pgsql: Make isolationtester more robust on locked commands - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Make isolationtester more robust on locked commands
Date
Msg-id E1QjFAZ-0001at-C3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make isolationtester more robust on locked commands

Noah Misch diagnosed the buildfarm problems in the isolation tests
partly as failure to differentiate backends properly; the old code was
using backend IDs, which is not good enough because a new backend might
use an already used ID.  Use PIDs instead.

Also, the code was purposely careless about other concurrent activity,
because it isn't expected; and in fact, it doesn't affect the vast
majority of the time.  However, it can be observed that autovacuum can
block tables for long enough to cause sporadic failures.  The new code
accounts for that by ignoring locks held by processes not explicitly
declared in our spec file.

Author: Noah Misch

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c8dfc892327b1a1e14efe110b0f1f267ef56c7a9

Modified Files
--------------
src/test/isolation/isolationtester.c |  107 +++++++++++++++++++++++++++++-----
1 files changed, 93 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Add expected regress output on stricter isolation levels
Next
From: Robert Haas
Date:
Subject: pgsql: Minor improvement to pg_seclabel documentation.