pgsql: In planner, don't assume that empty parent tables aren't really - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: In planner, don't assume that empty parent tables aren't really
Date
Msg-id E1QhTgq-0000po-Kx@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
In planner, don't assume that empty parent tables aren't really empty.

There's a heuristic in estimate_rel_size() to clamp the minimum size
estimate for a table to 10 pages, unless we can see that vacuum or analyze
has been run (and set relpages to something nonzero, so this will always
happen for a table that's actually empty).  However, it would be better
not to do this for inheritance parent tables, which very commonly are
really empty and can be expected to stay that way.  Per discussion of a
recent pgsql-performance report from Anish Kejariwal.  Also prevent it
from happening for indexes (although this is more in the nature of
documentation, since CREATE INDEX normally initializes relpages to
something nonzero anyway).

Back-patch to 9.0, because the ability to collect statistics across a
whole inheritance tree has improved the planner's estimates to the point
where this relatively small error makes a significant difference.  In the
referenced report, merge or hash joins were incorrectly estimated as
cheaper than a nestloop with inner indexscan on the inherited table.
That was less likely before 9.0 because the lack of inherited stats would
have resulted in a default (and rather pessimistic) estimate of the cost
of a merge or hash join.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f3ff0433ab32fdc69da3c8f8e691ef6b4366559c

Modified Files
--------------
src/backend/optimizer/util/plancat.c |   44 +++++++++++++++++++++++----------
1 files changed, 30 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix broken markup
Next
From: Tom Lane
Date:
Subject: pgsql: In planner, don't assume that empty parent tables aren't really