pgsql: Fix another oversight in logging of changes in postgresql.conf s - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix another oversight in logging of changes in postgresql.conf s
Date
Msg-id E1QfICy-0005zU-0k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix another oversight in logging of changes in postgresql.conf settings.

We were using GetConfigOption to collect the old value of each setting,
overlooking the possibility that it didn't exist yet.  This does happen
in the case of adding a new entry within a custom variable class, as
exhibited in bug #6097 from Maxim Boguk.

To fix, add a missing_ok parameter to GetConfigOption, but only in 9.1
and HEAD --- it seems possible that some third-party code is using that
function, so changing its API in a minor release would cause problems.
In 9.0, create a near-duplicate function instead.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7c884433992cce9f53d87ca3a5d0d629e21af300

Modified Files
--------------
src/backend/commands/extension.c  |    6 +++---
src/backend/utils/misc/guc-file.l |    6 +++---
src/backend/utils/misc/guc.c      |   16 ++++++++++++----
src/include/utils/guc.h           |    3 ++-
4 files changed, 20 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Introduce a pipe between postmaster and each backend, which can
Next
From: Tom Lane
Date:
Subject: pgsql: Fix another oversight in logging of changes in postgresql.conf s