pgsql: Expose the "*VALUES*" alias that we generate for a stand-alone V - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Expose the "*VALUES*" alias that we generate for a stand-alone V
Date
Msg-id E1QSwqM-0005u0-Qm@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Expose the "*VALUES*" alias that we generate for a stand-alone VALUES list.

We were trying to make that strictly an internal implementation detail,
but it turns out that it's exposed anyway when dumping a view defined
like
    CREATE VIEW test_view AS VALUES (1), (2), (3) ORDER BY 1;
This comes out as
    CREATE VIEW ... ORDER BY "*VALUES*".column1;
which fails to parse when reloading the dump.

Hacking ruleutils.c to suppress the column qualification looks like it'd
be a risky business, so instead promote the RTE alias to full-fledged
usability.

Per bug #6049 from Dylan Adams.  Back-patch to all supported branches.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f3f651677349a87311b83f48eed18566347adfe4

Modified Files
--------------
src/backend/parser/analyze.c |    3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Expose the "*VALUES*" alias that we generate for a stand-alone V
Next
From: Tom Lane
Date:
Subject: pgsql: Expose the "*VALUES*" alias that we generate for a stand-alone V