pgsql: Fix SortTocFromFile() to cope with lines that are too long for i - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix SortTocFromFile() to cope with lines that are too long for i
Date
Msg-id E1Q7rKe-00066T-PP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix SortTocFromFile() to cope with lines that are too long for its buffer.

The original coding supposed that a dump TOC file could never contain lines
longer than 1K.  The folly of that was exposed by a recent report from
Per-Olov Esgard.  We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.

Back-patch to all supported branches, since it's always been like this.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e2c946018fe27e5b21d8e2cd00d05f33b19709a4

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c |   29 ++++++++++++++++++++++++-----
1 files changed, 24 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix SortTocFromFile() to cope with lines that are too long for i
Next
From: Tom Lane
Date:
Subject: pgsql: Fix SortTocFromFile() to cope with lines that are too long for i