pgsql: Revert incorrect memory-conservation hack in inheritance_planner - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Revert incorrect memory-conservation hack in inheritance_planner
Date
Msg-id E1PdSw1-0002sd-KZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert incorrect memory-conservation hack in inheritance_planner().

This reverts commit d1001a78ce612a16ea622b558f5fc2b68c45ab4c of 2010-12-05,
which was broken as reported by Jeff Davis.  The problem is that the
individual planning steps may have side-effects on substructures of
PlannerGlobal, not only the current PlannerInfo root.  Arranging to keep
all such side effects in the main planning context is probably possible,
but it would change this from a quick local hack into a wide-ranging and
rather fragile endeavor.  Which it's not worth.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f0f36045b2e3d037bb7647d84373404fa4ba9588

Modified Files
--------------
src/backend/optimizer/plan/planner.c |   68 +++++++--------------------------
1 files changed, 15 insertions(+), 53 deletions(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Make sure walsender state is only read while holding the spinloc
Next
From: Tom Lane
Date:
Subject: pgsql: Code review for postmaster.pid contents changes.