pgsql: Remove optreset from src/port/ implementations of getopt and get - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove optreset from src/port/ implementations of getopt and get
Date
Msg-id E1PTLIL-0003nM-Ov@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove optreset from src/port/ implementations of getopt and getopt_long.

We don't actually need optreset, because we can easily fix the code to
ensure that it's cleanly restartable after having completed a scan over the
argv array; which is the only case we need to restart in.  Getting rid of
it avoids a class of interactions with the system libraries and allows
reversion of my change of yesterday in postmaster.c and postgres.c.

Back-patch to 8.4.  Before that the getopt code was a bit different anyway.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=61b53695fbbedb7fa9d394e71bf2affdc494e6b0

Modified Files
--------------
src/backend/postmaster/postmaster.c |    5 ++---
src/backend/tcop/postgres.c         |    5 ++---
src/include/getopt_long.h           |    1 -
src/port/getopt.c                   |   20 +++++++++++---------
src/port/getopt_long.c              |   20 +++++++++++---------
5 files changed, 26 insertions(+), 25 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Fix inconsequential FILE pointer leakage
Next
From: Tom Lane
Date:
Subject: pgsql: Remove optreset from src/port/ implementations of getopt and get