pgsql: Force default wal_sync_method to be fdatasync on Linux. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Force default wal_sync_method to be fdatasync on Linux.
Date
Msg-id E1PQUtx-0006yL-Jq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Force default wal_sync_method to be fdatasync on Linux.

Recent versions of the Linux system header files cause xlogdefs.h to
believe that open_datasync should be the default sync method, whereas
formerly fdatasync was the default on Linux.  open_datasync is a bad
choice, first because it doesn't actually outperform fdatasync (in fact
the reverse), and second because we try to use O_DIRECT with it, causing
failures on certain filesystems (e.g., ext4 with data=journal option).
This part of the patch is largely per a proposal from Marti Raudsepp.
More extensive changes are likely to follow in HEAD, but this is as much
change as we want to back-patch.

Also clean up confusing code and incorrect documentation surrounding the
fsync_writethrough option.  Those changes shouldn't result in any actual
behavioral change, but I chose to back-patch them anyway to keep the
branches looking similar in this area.

In 9.0 and HEAD, also do some copy-editing on the WAL Reliability
documentation section.

Back-patch to all supported branches, since any of them might get used
on modern Linux versions.

Branch
------
REL8_1_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6b2c0eab1f2f0b86ebf2721749689e6b839bc279

Modified Files
--------------
doc/src/sgml/config.sgml                      |    8 +++++---
src/backend/access/transam/xlog.c             |   10 +++++-----
src/backend/storage/file/fd.c                 |    9 +++++----
src/backend/utils/misc/postgresql.conf.sample |    2 +-
src/include/port/linux.h                      |   10 ++++++++++
src/include/port/win32.h                      |   14 +++++++++-----
6 files changed, 35 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Force default wal_sync_method to be fdatasync on Linux.
Next
From: Tom Lane
Date:
Subject: pgsql: Force default wal_sync_method to be fdatasync on Linux.