pgsql: Add a stack overflow check to copyObject(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add a stack overflow check to copyObject().
Date
Msg-id E1PPoiE-0003CO-Jh@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add a stack overflow check to copyObject().

There are some code paths, such as SPI_execute(), where we invoke
copyObject() on raw parse trees before doing parse analysis on them.  Since
the bison grammar is capable of building heavily nested parsetrees while
itself using only minimal stack depth, this means that copyObject() can be
the front-line function that hits stack overflow before anything else does.
Accordingly, it had better have a check_stack_depth() call.  I did a bit of
performance testing and found that this slows down copyObject() by only a
few percent, so the hit ought to be negligible in the context of complete
processing of a query.

Per off-list report from Toshihide Katayama.  Back-patch to all supported
branches.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ee6c8875a567c591a6602a40f4c064641806e4bc

Modified Files
--------------
src/backend/nodes/copyfuncs.c |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add a stack overflow check to copyObject().
Next
From: Tom Lane
Date:
Subject: pgsql: Add a stack overflow check to copyObject().