pgsql: Add new buffers_backend_fsync field to pg_stat_bgwriter. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Add new buffers_backend_fsync field to pg_stat_bgwriter.
Date
Msg-id E1PI39D-00068k-3G@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add new buffers_backend_fsync field to pg_stat_bgwriter.

This new field counts the number of times that a backend which writes a
buffer out to the OS must also fsync() it.  This happens when the
bgwriter fsync request queue is full, and is generally detrimental to
performance, so it's good to know when it's happening.  Along the way,
log a new message at level DEBUG1 whenever we fail to hand off an fsync,
so that the problem can also be seen in examination of log files
(if the logging level is cranked up high enough).

Greg Smith, with minor tweaks by me.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=3134d8863e8473e3ed791e27d484f9e548220411

Modified Files
--------------
doc/src/sgml/monitoring.sgml         |    6 ++++--
src/backend/catalog/system_views.sql |    1 +
src/backend/postmaster/bgwriter.c    |   16 ++++++++++++----
src/backend/postmaster/pgstat.c      |    1 +
src/backend/storage/smgr/md.c        |    3 +++
src/backend/utils/adt/pgstatfuncs.c  |    7 +++++++
src/include/catalog/catversion.h     |    2 +-
src/include/catalog/pg_proc.h        |    2 ++
src/include/pgstat.h                 |    2 ++
src/test/regress/expected/rules.out  |    2 +-
10 files changed, 34 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Remove outdated comments from the regression test files.
Next
From: andrewd@pgfoundry.org (User Andrewd)
Date:
Subject: pgbuildfarm - client-code: Call run_build.pl directly.