pgsql: Work around make 3.80 bug with long expansions of $(eval). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Work around make 3.80 bug with long expansions of $(eval).
Date
Msg-id E1PHgil-00035A-NA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Work around make 3.80 bug with long expansions of $(eval).

3.80 breaks if the expansion of $(eval) is long enough to require expansion
of its internal variable_buffer.  For the purposes of $(recurse) that means
it'll work so long as no single evaluation of _create_recursive_target
produces more than 195 bytes.  We can manage that by looping over
subdirectories outside the call instead of complicating the generated rule.
This coding is simpler and more readable anyway.

Or at least, this works for me.  We'll see if the buildfarm likes it.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=1bd201214965b3eba23bee2c4ce4c14accde170f

Modified Files
--------------
src/Makefile.global.in |   45 +++++++++++++++++++++++----------------------
1 files changed, 23 insertions(+), 22 deletions(-)


pgsql-committers by date:

Previous
From: andrewd@pgfoundry.org (User Andrewd)
Date:
Subject: pgbuildfarm - client-code: add logic for selecting a single branch to
Next
From: Tom Lane
Date:
Subject: pgsql: Fix canAcceptConnections() bugs introduced by replication-relate