pgsql: Fix old oversight in const-simplification of COALESCE() expressi - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix old oversight in const-simplification of COALESCE() expressi
Date
Msg-id E1PH0Ab-0007O0-GN@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix old oversight in const-simplification of COALESCE() expressions.

Once we have found a non-null constant argument, there is no need to
examine additional arguments of the COALESCE.  The previous coding got it
right only if the constant was in the first argument position; otherwise
it tried to simplify following arguments too, leading to unexpected
behavior like this:

regression=# select coalesce(f1, 42, 1/0) from int4_tbl;
ERROR:  division by zero

It's a minor corner case, but a bug is a bug, so back-patch all the way.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d7304244e26b92d533f7e44f0afbcf1ff2f46286

Modified Files
--------------
src/backend/optimizer/util/clauses.c |    6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix old oversight in const-simplification of COALESCE() expressi
Next
From: Robert Haas
Date:
Subject: pgsql: Move copydir() prototype into its own header file.