pgsql: Behave correctly if INSERT ... VALUES is decorated with addition - Mailing list pgsql-committers

Behave correctly if INSERT ... VALUES is decorated with additional clauses.

In versions 8.2 and up, the grammar allows attaching ORDER BY, LIMIT,
FOR UPDATE, or WITH to VALUES, and hence to INSERT ... VALUES.  But the
special-case code for VALUES in transformInsertStmt() wasn't expecting any
of those, and just ignored them, leading to unexpected results.  Rather
than complicate the special-case path, just ensure that the presence of any
of those clauses makes us treat the query as if it had a general SELECT.
Per report from Hitoshi Harada.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9e718e6116d2ace2faff8cce3d907fcf69bb6416

Modified Files
--------------
src/backend/parser/analyze.c |   11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)