pgsql: Prevent show_session_authorization from crashing when session_au - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Prevent show_session_authorization from crashing when session_au
Date
Msg-id E1Oysof-0006ho-0N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent show_session_authorization from crashing when session_authorization
hasn't been set.

The only known case where this can happen is when show_session_authorization
is invoked in an autovacuum process, which is possible if an index function
calls it, as for example in bug #5669 from Andrew Geery.  We could perhaps
try to return a sensible value, such as the name of the cluster-owning
superuser; but that seems like much more trouble than the case is worth,
and in any case it could create new possible failure modes.  Simply
returning an empty string seems like the most appropriate fix.

Back-patch to all supported versions, even those before autovacuum, just
in case there's another way to provoke this crash.

Branch
------
REL8_0_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=1ea2c83807f703157a503b21187594fea28b5087

Modified Files
--------------
src/backend/commands/variable.c |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Prevent show_session_authorization from crashing when session_au
Next
From: Tom Lane
Date:
Subject: pgsql: Prevent show_session_authorization from crashing when session_au