Re: Add notes to pg_combinebackup docs - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Add notes to pg_combinebackup docs
Date
Msg-id E0726351-5711-4FC7-BF24-817B14040A75@yesql.se
Whole thread Raw
In response to Re: Add notes to pg_combinebackup docs  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Add notes to pg_combinebackup docs
Re: Add notes to pg_combinebackup docs
List pgsql-hackers
> On 18 Apr 2024, at 20:11, Robert Haas <robertmhaas@gmail.com> wrote:

> 2. As (1), but make check_control_files() emit a warning message when
> the problem case is detected.

Being in the post-freeze part of the cycle, this seems like the best option.

> 3. As (2), but also add a command-line option to pg_combinebackup to
> flip the checksum flag to false in the control file.

I don't think this is the way to go, such an option will be plastered on to
helpful tutorials which users will copy/paste from even when they don't need
the option at all, only to disable checksums when there was no reason for doing
so.

> We could perhaps consider doing (2) for now and (5) for a future
> release, or something like that.

+1

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [18] clarify the difference between pg_wchar, wchar_t, and Unicode code points
Next
From: Robert Haas
Date:
Subject: Re: Add notes to pg_combinebackup docs