On Tue Sep 22, 2026 at 10:58 PM CEST, Manu wrote:
>> I also think I changed the pg_upgrade to do the correct thing, but I'm
>> not sure how to test this (even manually). Because part of it would
>> only be relevant once we support upgrading from PG18. So for now the
>> upgrade_code I haven't actually run.
>
> That is still true, and unfortunately that code does not work.
Thank you for testing the patch and finding these issues. And to be
clear I had by this point tested this code manually (but that was a long
time ago) and written regression tests that should catch these issues.
> 1. pg_dump against any older server fails
> ------------------------------------------
Yeah this version number bitrotted over time due to new releases
without this patch in it. Fixed now. (this is a gap in our CI, but the
buildfarm would have caught this quickly after commit)
> 2. Every pg_dump of a database with an owned-schema extension warns
> --------------------------------------------------------------------
>
> pg_dump: warning: could not resolve dependency loop among these items:
> pg_dump: detail: EXTENSION loopdemo_owned (ID 2 OID 16386)
> pg_dump: detail: SCHEMA loopdemo_owned (ID 8 OID 16385)
I think this was the best find. Fixed now. And I also included a
separate patch that fails the test_pg_dump regression test if any
warning is emitted by pg_dump/pg_restore so that CI will catch these
kind of failures in the future.
> 3. test_pg_dump cannot be run on its own any more
> --------------------------------------------------
>
> make -C src/test/modules/test_pg_dump check
Fixed now (needed a small Makefile addition). I think I had only tested
it with meson (and CI runs the full test suite not specific tests).
