On Tue, 3 Feb 2026 at 11:20, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> v2-0001:
>
> This doesn't really read the first 80 lines of the combined diff.
> Lines with more than 1023 characters will be counted and printed as
> multiple lines. I don't think this is a problem but clearing this
> would be helpful. Other than that, it looks good to me.
I was annoyed by this, so I actually fixed it (manually tested by
changing the buffer to 10 bytes). This meant I needed to introduce
DIAG_DETAIL and DIAG_END, like we already had NOTE_DETAIL and NOTE_END.
> v2-0002:
>
> I am just curious if test failure can cause file descriptors not being
> properly closed and then the IPC::Run:run() call will hang
> indefinitely like the pg_ctl case. Other than that, it looks good to
> me.
No, this issue only happens because for the 'pg_ctl restart' process,
its the child postmaster process outlives the pg_ctl process, WHILE
still having the stdout/stderr file descriptor open. As long as all the
subprocesses exit, the file descriptor will be closed by the OS
automatically. So, this problem really only occurs in these daemon
spawning situations. Which for us in practice is only for pg_ctl
start/restart.
