Re: Leftover member in openssl part of Port struct - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Leftover member in openssl part of Port struct
Date
Msg-id DE3CE48B-CEDA-4A9E-A09E-4A3F63D0A4A0@yesql.se
Whole thread Raw
In response to Re: Leftover member in openssl part of Port struct  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 31 Aug 2016, at 15:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> When SSL renegotiation was removed in 426746b9 the only consumer of the openssl
>> specific count member in the Port struct was removed, but the member was left
>> together with a few updates to it which are unused.  Attached patch removes the
>> leftovers which now serves no purpose unless I’m missing something.
>
> Hm, well, we can't remove those case labels as control would then end
> up in the default case which throws an error.

Doh, I’ll go stand in the corner.

> But otherwise this seems
> sound.  Without renegotiation the count is not very useful anyway
> since it's likely to overflow (at least if long is 32 bits).

Yeah. Thanks for applying.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_sequence catalog
Next
From: Tom Lane
Date:
Subject: Re: pg_sequence catalog