Re: Persist injection points across server restarts - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Persist injection points across server restarts
Date
Msg-id D48BAF0D-71AD-44F1-9859-FBED8C38FDAB@yandex-team.ru
Whole thread Raw
In response to Persist injection points across server restarts  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

> On 21 May 2025, at 11:20, Michael Paquier <michael@paquier.xyz> wrote:
>
> Rebased, to fix a conflict I've introduced with a different commit.

I've looked into the patch set and have some more questions:
1. What if we flush many times? Is it supposed to overwrite injection_points.data?
2. What if we restart many times? first startup will remove the file... maybe remove it explicitly?
3. InjectionPoint private data is not handled, is it OK?
4. How session-local points are expected to be flushed? into which session they will be loaded? Maybe let's document
thatthey are not saved? 

Besides these, cool new abilities and a test for a bug, looks good to me.


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: Allow reading LSN written by walreciever, but not flushed yet
Next
From: Amit Langote
Date:
Subject: Re: generic plans and "initial" pruning