Re: psql not responding to SIGINT upon db reconnection - Mailing list pgsql-hackers

On Wed Apr 3, 2024 at 9:50 AM CDT, Jelte Fennema-Nio wrote:
> On Wed, 3 Apr 2024 at 16:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > If we do the latter, we will almost certainly get pushback from
> > distros who check for library ABI breaks.  I fear the comment
> > suggesting that we could remove it someday is too optimistic.
>
> Alright, changed patch 0002 to keep the variant. But remove it from
> the recently added switch/case. And also updated the comment to remove
> the "for awhile".

Removing from the switch statement causes a warning:

> [1/2] Compiling C object src/bin/psql/psql.p/command.c.o
> ../src/bin/psql/command.c: In function ‘wait_until_connected’:
> ../src/bin/psql/command.c:3803:17: warning: enumeration value ‘PGRES_POLLING_ACTIVE’ not handled in switch [-Wswitch]
>  3803 |                 switch (PQconnectPoll(conn))
>       |                 ^~~~~~

--
Tristan Partin
Neon (https://neon.tech)