[PATCH] Refactor parse_publication_options - Mailing list pgsql-hackers

From Miłosz Bieniek
Subject [PATCH] Refactor parse_publication_options
Date
Msg-id CVqp0ITYe3mo8Sp9p-lY8hjcuj1SxmM9kkLeeOoi3wgtvPbOkpqSxQ4rV7tgvEG9n4-TNlMOohV2U61e-6J8MoKPly5_NkpZ5JVSvJi_0d4=@bieniek.cc
Whole thread
Responses Re: Fix doc about pg_get_multixact_stats()
List pgsql-hackers
Hi,
While reading the code related to creating subscriptions and publications for logical replication I found a difference between passing options to parse_subscription_options and parse_publication_options.
To parse_publication_options function we pass all options separately, while in parse_subscription_options we use SubOpts.
IMO the usage of a struct instead of each option separately seems cleaner.
I attached a patch that creates a PubOpts struct and uses it in all parse_publication_options occurrences.

--
Miłosz Bieniek
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: missing possibility to use alternative translated month names in to_char function
Next
From: Rogers Wang
Date:
Subject: Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts