Re: Clean up some signal usage mainly related to Windows - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: Clean up some signal usage mainly related to Windows
Date
Msg-id CU09P3FQ4JB4.T8AHOQWH22YA@gonk
Whole thread Raw
In response to Re: Clean up some signal usage mainly related to Windows  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Clean up some signal usage mainly related to Windows
List pgsql-hackers
On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
> On 12.07.23 16:23, Tristan Partin wrote:
> > It has come to my attention that STDOUT_FILENO might not be portable and
> > fileno(3) isn't marked as signal-safe, so I have just used the raw 1 for
> > stdout, which as far as I know is portable.
>
> We do use STDOUT_FILENO elsewhere in the code, and there are even
> workaround definitions for Windows, so it appears it is meant to be used.

v3 is back to the original patch with newline being printed. Thanks.

--
Tristan Partin
Neon (https://neon.tech)

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Clean up some signal usage mainly related to Windows
Next
From: Alvaro Herrera
Date:
Subject: RelationGetIndexAttrBitmap comment outdated