Re: [PATCH] Missing dep on Catalog.pm in meson rules - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: [PATCH] Missing dep on Catalog.pm in meson rules
Date
Msg-id CT29G866OR1A.P5MR0P1UF545@gonk
Whole thread Raw
In response to Re: [PATCH] Missing dep on Catalog.pm in meson rules  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Missing dep on Catalog.pm in meson rules
List pgsql-hackers
On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote:
> Hi,
>
> On 2023-06-02 08:10:43 -0500, Tristan Partin wrote:
> > > I wonder if we instead could just make perl output the files it loads and
> > > handle dependencies automatically that way? But that's more work, so it's
> > > probably the right thing to go for the manual path for now.
> >
> > I am not familar with Perl enough (at all haha) to know if that is
> > possible. I don't know exactly what these Perl files do, but perhaps it
> > might make sense to have some global lookup table that is setup near the
> > beginning of the script.
>
> It'd be nice to have something more general - there are other perl modules we
> load, e.g.
> ./src/backend/catalog/Catalog.pm
> ./src/backend/utils/mb/Unicode/convutils.pm
> ./src/tools/PerfectHash.pm
>
>
> > perl_files = {
> >   'Catalog.pm': files('path/to/Catalog.pm'),
> >   ...
> > }
>
> I think you got it, but just to make sure: I was thinking of generating a
> depfile from within perl. Something like what you propose doesn't quite seems
> like a sufficient improvement.

Whatever I am proposing is definitely subpar to generating a depfile. So
if that can be done, that is the best option!

> > Otherwise, manual as it is in the original patch seems like an alright
> > compromise for now.
>
> Yea. I'm working on a more complete version, also dealing with dependencies on
> PerfectHash.pm.

Good to hear. Happy to review any patches :).

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: Kirk Wolak
Date:
Subject: Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function
Next
From: Greg Sabino Mullane
Date:
Subject: Prevent psql \watch from running queries that return no rows