Re: [PATCH] Missing dep on Catalog.pm in meson rules - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: [PATCH] Missing dep on Catalog.pm in meson rules
Date
Msg-id CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk
Whole thread Raw
In response to Re: [PATCH] Missing dep on Catalog.pm in meson rules  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Missing dep on Catalog.pm in meson rules
List pgsql-hackers
On Thu Jun 1, 2023 at 4:22 PM CDT, Dagfinn Ilmari Mannsåker wrote:
> On Thu, 1 Jun 2023, at 22:16, Tristan Partin wrote:
> > Could you create a variable for the file instead of calling files() 3
> > times?
> >
> >> catalog_pm = files('path/to/Catalog.pm')
>
> Sure, but which meson.build file should it go in? I know nothing about meson variable scoping.

Not a problem. In Meson, variables are globally-scoped. You can use
unset_variable() however to unset it.

In our case, we should add the ^line to src/backend/catalog/meson.build.
I would say just throw the line after the copyright comment. Hopefully
there isn't a problem with the ordering of the Meson file tree traversal
(ie the targets you are changing are configured after we get through
src/backend/catalog/meson.build).

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: "Fujii.Yuki@df.MitsubishiElectric.co.jp"
Date:
Subject: RE: Partial aggregates pushdown
Next
From: Richard Guo
Date:
Subject: Tighten a little bit the computation of potential commutator pairs