Re: Fix incorrect function comment of stringToNodeInternal - Mailing list pgsql-hackers

From Chao Li
Subject Re: Fix incorrect function comment of stringToNodeInternal
Date
Msg-id CD945FE8-323D-41A8-80BE-629956BE807D@gmail.com
Whole thread Raw
In response to Re: Fix incorrect function comment of stringToNodeInternal  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers


On Sep 25, 2025, at 17:54, Daniel Gustafsson <daniel@yesql.se> wrote:

On 25 Sep 2025, at 10:01, Chao Li <li.evan.chao@gmail.com> wrote:

There are 5 different cases, showing that there is not a unique way for what function name should be put to xxInternal() functions’ comment.

Is it deserve to take this opportunity to make all of them in a consistent format?

We don't have a policy on how to do function comments, and none of these
examples strike me as particularly confusing.  I don't think there is much
value in the churn from changing these from one flavor or another as they
aren't wrong.


Sure, then I withdraw the patch. Thank you very much for helping.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Fix incorrect function comment of stringToNodeInternal
Next
From: Bertrand Drouvot
Date:
Subject: Re: Add memory_limit_hits to pg_stat_replication_slots