Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi - Mailing list pgsql-committers

From Alexander Korotkov
Subject Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi
Date
Msg-id CAPpHfdvrmoZPwSgpxPwzSXrDGffyXQS=Df+Abzze9t-mk6WCxg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-committers
Tree view
On Thu, Apr 5, 2018 at 1:32 AM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
On Wed, Apr 4, 2018 at 7:29 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
Skip full index scan during cleanup of B-tree indexes when possible

Thank you for committing this.

It appears that patch contains some redundant variabled.  See warnings produced
by gcc-7.

nbtpage.c: In function '_bt_update_meta_cleanup_info':
nbtpage.c:121:15: warning: variable 'metaopaque' set but not used [-Wunused-but-set-variable]
  BTPageOpaque metaopaque;
               ^~~~~~~~~~
nbtree.c: In function '_bt_vacuum_needs_cleanup':
nbtree.c:790:15: warning: variable 'metaopaque' set but not used [-Wunused-but-set-variable]
  BTPageOpaque metaopaque;
               ^~~~~~~~~~

Attached patch fixes this.

Teodor already committed [1] better patch [2] from Kyotaro Horiguchi.  This question is closed.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

pgsql-committers by date:

Previous
From: Simon Riggs
Date:
Subject: pgsql: MERGE INSERT allows only one VALUES clause
Next
From: Alexander Korotkov
Date:
Subject: Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi