Re: Use correct collation in pg_trgm - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Use correct collation in pg_trgm
Date
Msg-id CAPpHfdvWbF2S6fsc+dF=7OjLG6iFXVcDH+MK0aVKzaH9iptLvQ@mail.gmail.com
Whole thread Raw
In response to Re: Use correct collation in pg_trgm  (Zsolt Parragi <zsolt.parragi@percona.com>)
Responses Re: Use correct collation in pg_trgm
List pgsql-hackers
Hi!

Thank you for working on this.

On Mon, Jan 26, 2026 at 3:24 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> > While reading through [1] I realized that the word boundary detection
> > also uses the wrong collation. Patch 0002 fixes that.
>
> Good catch, I considered checking that when I reviewed the patch, but
> I thought that it would be an issue with CJK languages, and I was
> completely wrong about that.
>
> Updated patch looks good, I only noticed two minor things:
>
> * the new test should have a newline at the end of the file
> * and probably a conditional skip based on locale availability, the
> citext_utf8.sql test case does something similar

I wonder about existing indexes, which already use default collation
not column collation.  Should we add a release note saying they might
be obsolete?  Alternatively, given we now have opclass options, we may
add a new opclass option defining whether to use column collation
(must be false for existing indexes).

------
Regards,
Alexander Korotkov
Supabase



pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Re: Use correct collation in pg_trgm
Next
From: Fujii Masao
Date:
Subject: Re: Exit walsender before confirming remote flush in logical replication