Re: pgsql: Multirange datatypes - Mailing list pgsql-committers

From Alexander Korotkov
Subject Re: pgsql: Multirange datatypes
Date
Msg-id CAPpHfdvO7xF2VGzjSOc---ruxGoAAxjVqHTtXW_2yLTSs=g1MA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Multirange datatypes  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Multirange datatypes  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Hi, Michael!

On Mon, Dec 21, 2020 at 10:34 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Sun, Dec 20, 2020 at 04:21:16AM +0000, Alexander Korotkov wrote:
> > Multirange datatypes
> >
> > Multiranges are basically sorted arrays of non-overlapping ranges with
> > set-theoretic operations defined over them.
>
> This commit is creating a compilation warning on Windows:
> multirangetypes.c(1033): warning C4715: 'multirange_constructor0' :
> not all control paths return a value
>
> See for example woodlouse:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2020-12-21%2001%3A42%3A28&stg=make
>
> Looking at the code, it is obvious that the compiler cannot understand
> that this should always return.  Please find attached a suggestion of
> patch.

Thank you for catching this!  Pushed.

------
Regards,
Alexander Korotkov



pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Fix compiler warning in multirange_constructor0()
Next
From: Alexander Korotkov
Date:
Subject: Re: pgsql: Multirange datatypes