Compiler warnings with stringRelOpts (was WIP: Fast GiST index build) - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
Date
Msg-id CAPpHfdvLWtPxNCUcAYNEON3mrABO31=iE0Rh4=Rr_Qc7qYM_cg@mail.gmail.com
Whole thread Raw
Responses Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
List pgsql-hackers
String-formatted relopts was never used before, but I've used it in buffering GiST index build patch and encountered with following compiler warnings:

reloptions.c:259: warning: initializer-string for array of chars is too long
reloptions.c:259: warning: (near initialization for ‘stringRelOpts[0].default_val’)

It is caused by definition of default field of relopt_string structure as 1-length character array. This seems to be a design flaw in the reloptions.c code. Any thoughts?

------
With best regards,
Alexander Korotkov.

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: WIP: Fast GiST index build
Next
From: Anssi Kääriäinen
Date:
Subject: Re: Transient plans versus the SPI API