Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY) - Mailing list pgsql-committers

From Alexander Korotkov
Subject Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
Date
Msg-id CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com
Whole thread
In response to pgsql: Disable logical decoding after REPACK (CONCURRENTLY)  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-committers
Hi!

On Wed, May 27, 2026 at 9:14 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> Disable logical decoding after REPACK (CONCURRENTLY)
>
> REPACK (CONCURRENTLY) uses a temporary logical replication slot, which
> is dropped once done, but it wasn't calling RequestDisableLogicalDecoding(),
> leaving effective_wal_level stuck at 'logical'.
>
> Fix by adding a Boolean flag to ReplicationSlotDropAcquired() to have it
> request to disable logical decoding, and passing it as true on REPACK.
> Other callers of that function preserve their existing behavior.
>
> Author: Imran Zaheer <imran.zhir@gmail.com>
> Reviewed-by: shveta malik <shveta.malik@gmail.com>
> Discussion: https://postgr.es/m/CA+UBfaktds57dw2M8BEv_kS-=ixph3w+3MxKixtaDQMi_k7Ybg@mail.gmail.com

This seams to cause buildfarm failures, for instance
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2026-05-27%2018%3A25%3A00

------
Regards,
Alexander Korotkov
Supabase



pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
Next
From: Masahiko Sawada
Date:
Subject: pgsql: Fix race between ProcSignalInit() and EmitProcSignalBarrier().