Re: Asynchronous MergeAppend - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Asynchronous MergeAppend
Date
Msg-id CAPpHfdueTP03n-icH+OgT4-Odhu6M4T1-fNZTymoqSj8QcPARA@mail.gmail.com
Whole thread
In response to Re: Asynchronous MergeAppend  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: Asynchronous MergeAppend
List pgsql-hackers
Hi Richard,
Hi Etsuro,

On Mon, Apr 6, 2026 at 8:33 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>
> On Mon, Apr 6, 2026 at 12:40 PM Richard Guo <guofenglinux@gmail.com> wrote:
> > On Sun, Apr 5, 2026 at 11:25 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> > > I'm going to went through this patchset another time tomorrow and push
> > > it on Monday if there are no objections.
> >
> > I completely understand the desire to get this committed ahead of the
> > feature freeze.  However, I'm concerned that a one-day notice over the
> > Easter weekend is simply too short for the community to see the
> > announcement, let alone provide feedback, especially since this is a
> > pretty big feature.
> >
> > I don't have any specific technical feedback on the patchset itself,
> > as I haven't reviewed it.  My only hesitation is the short notice
> > period.  That said, if you are highly confident in its readiness, I
> > will defer to your judgment.
>
> First, my apologies for not having reviewed this patch.  I was
> planning to do so, but didn't have time for that, due to other
> priorities.
>
> I hate to say this, but as mentioned by Richard, this is a pretty big,
> complex feature, so I also think the one-day notice is too short.

Thank you for your feedback.  I would say that this patch is here for
quite long, and it's pretty straightforward.  It passed many rounds of
review by Matheus Alcantara.  I've done a lot of minor cleanups and
improvements, and reorganized changes into multiple patches.  The only
major change I did is actually a simplification which come from the
fact that only initial heap filling is effectively async [1].  Today
Matheus gave a feedback on my changes.

Surely, I wouldn't commit this patch without giving you a chance to
review.  We can postpone it till early PG20 development cycle.  But if
you find it possible to take a look at this patch during Apr 7, let me
know.

Links.
1. https://www.postgresql.org/message-id/CAPpHfdsO8zYpDW%3D%3DD6T5N0cJ%2BAzK7a_OyXJoYU1kFi%3DxZFTLuQ%40mail.gmail.com
2. https://www.postgresql.org/message-id/DHMH23M7UOFS.12W6PUDI1I3NH%40gmail.com

------
Regards,
Alexander Korotkov
Supabase



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Asynchronous MergeAppend
Next
From: Peter Smith
Date:
Subject: Re: DOC: pg_publication_rel.prrelid says sequences are possible