Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.
Date
Msg-id CAPpHfduW_LbrU1JPtEDek5Fj3_=GZRU=qvFMyg7hnky7BLCGVw@mail.gmail.com
Whole thread Raw
In response to Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.  ("Anton A. Melnikov" <a.melnikov@postgrespro.ru>)
Responses Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.
Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.
List pgsql-hackers
Hi, Anton!

On Mon, Dec 4, 2023 at 3:50 AM Anton A. Melnikov <a.melnikov@postgrespro.ru> wrote:
Thanks for remarks!

On 28.11.2023 21:34, Alexander Korotkov wrote:
> After examining the second patch
> ("v2-0001-Add-restartpoint-stats.patch"), it appears that adding
> additional statistics as outlined in the patch is the most suitable
> approach to address the concerns raised. This solution provides more
> visibility into the system's behavior without altering its core
> mechanics.

Agreed. I left only this variant of the patch and rework it due to commit 96f05261.
So the new counters is in the pg_stat_checkpointer view now.
Please see the v3-0001-add-restartpoints-stats.patch attached.


> However, it's essential that this additional functionality
> is accompanied by comprehensive documentation to ensure clear
> understanding and ease of use by the PostgreSQL community.
>
> Please consider expanding the documentation to include detailed
> explanations of the new statistics and their implications in various
> scenarios.

In the separate v3-0002-doc-for-restartpoints-stats.patch i added the definitions
of the new counters into the "28.2.15. pg_stat_checkpointer" section
and explanation of them with examples into the "30.5.WAL Configuration" one.

Would be glad for any comments and and concerns.

I made some grammar corrections to the docs and have written the commit message.

I think this patch now looks good.  I'm going to push this if there are no objections.

------
Regards,
Alexander Korotkov
 
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Make all Perl warnings fatal
Next
From: Tom Lane
Date:
Subject: Re: authentication/t/001_password.pl trashes ~/.psql_history