Hi, Daniil!
On Wed, Apr 1, 2026 at 10:44 AM Daniil Davydov <3danissimo@gmail.com> wrote:
> Thank you very much for your comments!
> Please, see an updated patch.
Thank you for your work on this subject! I've some notes about the patch.
1) The changes in guc.c allows autovacuum parallel leader to accept
changes in not just cost-based GUCs, but any GUCs. That should be no
problem, because parallel workers have their own copies of GUC
variables, but I think this worth comment.
2) Maximum value for autovacuum_parallel_workers reloption is defined
as literally 1024, while max value for autovacuum_max_parallel_workers
is defined as MAX_PARALLEL_WORKER_LIMIT (also 1024). Should we define
max value for reloption as MAX_PARALLEL_WORKER_LIMIT as well?
3) Some paragraphs were moved from vacuum.sgml to maintenance.sgml.
It particular it references <replaceable
class="parameter">integer</replaceable, which is related to PARALLEL
option syntax: (PARALLEL integer). Now it becoming unclear and needs
to be revised.
4) I also think maintenance.sgml should mention the new reloption.
5) I think it worth having a test which check that setting
autovacuum_parallel_workers to 0 disables the parallel autovacuum for
given table.
6) Minor grammar issue in PVSharedCostParams comment, it must be
"vacuum workers compare" (plural subject).
------
Regards,
Alexander Korotkov
Supabase
