Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST - Mailing list pgsql-committers

From Alexander Korotkov
Subject Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST
Date
Msg-id CAPpHfdu+ZSp2rB0KOKYb971sfjGgOs20ACmna0ZMb4EiU=woTg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-committers
On Thu, Sep 19, 2019 at 11:13 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Erik Rijkers <er@xs4all.nl> writes:
> Oops:
>       create_index                 ... ok          634 ms
>       create_index_spgist          ... FAILED      438 ms
>       create_view                  ... ok          329 ms

I'm betting the issue is breaking the Datum abstraction here:

-                   scan->xs_orderbyvals[i] = Float8GetDatum(distanceValues[i]);
+                   scan->xs_orderbyvals[i] = item->distances[i].value;

Overseen by me.  Will fix immediately.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Fix oversight in backpatch of 6cae9d2c10