Re: BUG #17066: Cache lookup failed when null (iso-8859-1) is passed as anycompatiblemultirange - Mailing list pgsql-bugs

From Alexander Korotkov
Subject Re: BUG #17066: Cache lookup failed when null (iso-8859-1) is passed as anycompatiblemultirange
Date
Msg-id CAPpHfdtgd42dTehaiPqqP7v978oGSFHjLo_3=D_=UWzFTSwOrg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #17066: Cache lookup failed when null (iso-8859-1) is passed as anycompatiblemultirange  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #17066: Cache lookup failed when null (iso-8859-1) is passed as anycompatiblemultirange  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Wed, Jul 21, 2021 at 12:54 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
> > Do I understand correctly that enforce_generic_type_consistency() is
> > called only after check_generic_type_consistency() returned true?
> > If so, that means some of the checks are redundant.  Therefore, we can
> > replace ereport()'s with Assert()'s.
>
> They are not redundant, IIRC.  I forget the exact mechanism for
> reaching them, but it likely has something to do with aggregates
> or variadic functions.

If checks aren't redundant, there should be cases when they don't
pass.  It would be nice to identify these cases and add them to the
regression tests.  I didn't manage to do this yet.

> In any case, apologies for taking so long to get back to this.  Here's
> a proposed patch (based in part on Neil's earlier patch).

Thank you!  I'll review this and come back to you.

------
Regards,
Alexander Korotkov



pgsql-bugs by date:

Previous
From: Palle Girgensohn
Date:
Subject: Re: BUG #16696: Backend crash in llvmjit
Next
From: Pawel Kudzia
Date:
Subject: Re: IRe: BUG #16792: silent corruption of GIN index resulting in SELECTs returning non-matching rows