Re: Add SPLIT PARTITION/MERGE PARTITIONS commands - Mailing list pgsql-hackers

On Wed, Dec 10, 2025 at 1:22 AM Dmitry Koval <d.koval@postgrespro.ru> wrote:
> Thank you for your corrections!
> Two questions:
> ----
>
> 1) "v65-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch"
>   patch, "src/backend/partitioning/partbounds.c" file,
> "check_two_partitions_bounds_range" function.
>
> Old comment (v64)
>
> +       /*
> +        * lower1=false (the second to last argument) for correct comparison of
> +        * lower and upper bounds.
> +        */
>
> was changed to (v65)
>
> +       /*
> +        * cmpval == false for the correct comparison result of the lower and
> +        * upper bounds.
> +        */
>
> Maybe it's better to keep the old comment (or keep its meaning)?
> ----
>
> 2) "v65-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch"
> patch, "src/backend/parser/parse_utilcmd.c" file, "checkPartition" function.
>
> The third argument of function was changed from "is_merge" (v64) to
> "isMerge" (v65). Maybe the function description should be changed in
> the same way?
>
> + * is_merge: true indicates the operation is "ALTER TABLE ... MERGE
> PARTITIONS";

Thank you for catching this.  Both accepted.

------
Regards,
Alexander Korotkov
Supabase