Re: Removing unneeded self joins - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Removing unneeded self joins
Date
Msg-id CAPpHfdt=f7ZOnaH+DjkxYYgmsZE7i1KChHCqrMd9SwzOMBt__Q@mail.gmail.com
Whole thread Raw
In response to Re: Removing unneeded self joins  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
On Mon, Feb 24, 2025 at 12:57 PM Alexander Korotkov
<aekorotkov@gmail.com> wrote:
> On Mon, Feb 24, 2025 at 12:12 AM Andrei Lepikhov <lepihov@gmail.com> wrote:
> > On 23/2/2025 22:15, Alexander Korotkov wrote:
> > > There is my attempt to implement this approach.  Getting rid of local
> > > variable (and computation of the same value other way) required to
> > > change arguments of remove_rel_from_eclass() as well.  I'm going to
> > > further polish this tomorrow.
> > I passed through the patch. It works correctly.
> >
> > Multiple ifs in a single routine is not ideal.
>
> I would say there is a brachcing anyway.  Even if it is inside
> adjust_relid_set().  Patch makes it more explicit.  Ideal or not, I
> don't think it gets worse.

I've added a commit message to the patch.  I'm going to push it if no
objections.

------
Regards,
Alexander Korotkov
Supabase

Attachment

pgsql-hackers by date:

Previous
From: Nisha Moond
Date:
Subject: Race condition in replication slot usage introduced by commit f41d846
Next
From: Alexander Korotkov
Date:
Subject: Re: Removing unneeded self joins