Re: collect_corrupt_items_vacuum.patch - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: collect_corrupt_items_vacuum.patch
Date
Msg-id CAPpHfdsVVAdaGAJgoOBAJ+6EGaCdsUi=wbgQAc3+8X_qtUr=Qg@mail.gmail.com
Whole thread Raw
In response to Re: collect_corrupt_items_vacuum.patch  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: collect_corrupt_items_vacuum.patch
List pgsql-hackers
Hi, Alexander.

On Tue, Nov 7, 2023 at 1:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
> It looks like the v2 patch doesn't fix the original issue. Maybe I miss
> something, but with the patch applied, I see the failure immediately,
> though without the patch several iterations are needed to get it.


That's a bug in the patch.  Thank you for cathing it.  It should start
calculation from latestCompletedXid + 1, not InvalidTransactionId.
Please, check the revised patch.

------
Regards,
Alexander Korotkov

Attachment

pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Protocol question regarding Portal vs Cursor
Next
From: Alvaro Herrera
Date:
Subject: Re: Call pqPipelineFlush from PQsendFlushRequest