Request a Demo
Home   >   mailing lists

Re: Typo in version check in postgresAcquireSampleRowsFunc - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Typo in version check in postgresAcquireSampleRowsFunc
Date
Msg-id CAPmGK16E0o1AUpe=kt5Odo6u-2jVpKTgYkefBaEL0TrWagGfyw@mail.gmail.com
Whole thread
In response to Re: Typo in version check in postgresAcquireSampleRowsFunc  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Sep 28, 2026 at 8:49 PM Chao Li <li.evan.chao@gmail.com> wrote:
> LGTM. 90500 is for 9.5, there is 90600 for 9.6 also less than 95000.

Yeah, this causes an unexpected error when the remote server is 9.5 or 9.6:

alter foreign table ft1 options (add analyze_sampling 'bernoulli');
analyze ft1;
ERROR:  remote server does not support TABLESAMPLE feature

Will push.  Thanks for looking!

Best regards,
Etsuro Fujita

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw: transaction mode inheritance corner cases
Next
From: Etsuro Fujita
Date:
Subject: Re: Typo in version check in postgresAcquireSampleRowsFunc