Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw - Mailing list pgsql-hackers

On Mon, Feb 23, 2026 at 8:01 AM Andreas Karlsson <andreas@proxel.se> wrote:
> On 2/22/26 12:10 PM, Etsuro Fujita wrote:
> >> /*
> >>    * Checks the value of password_required, defaults to true
> >>    * if not defined. The mapping has been pre-validated.
> >>    */
> >
> > I like your wording.  I am not a native speaker either, though.  This
> > would be nitpicking, but I think it is better to clearly mention what
> > the function returns.  How about modifying it a bit, like this?
> >
> > /*
> >   * Check and return the value of password_required, if defined; otherwise,
> >   * return true, which is the default value of it.  The mapping has been
> >   * pre-validated.
> >   */
> No strong opinion. I would be fine with either. I do not think saying
> that it returns is necessary since you can see that from the function
> definition but it does not really harm either.

Ok.  I like the modified version as it also keeps the existing comment
to some extent, so I'd like to go with it.  Updated patch attached.  I
will push and back-patch it to all supported versions if there are no
objections from others.

Thanks!

Best regards,
Etsuro Fujita