Re: [PATCH] analyze: move elevel calculation into do_analyze_rel() - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [PATCH] analyze: move elevel calculation into do_analyze_rel()
Date
Msg-id CAPmGK14Mxuv+O7WauBEDN6usnPq77E=p90FU3C22=QJcQogMpA@mail.gmail.com
Whole thread
In response to Re: [PATCH] analyze: move elevel calculation into do_analyze_rel()  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
On Thu, Apr 2, 2026 at 8:29 AM Andreas Karlsson <andreas@proxel.se> wrote:
> On 3/31/26 7:56 PM, Lev Nikolaev wrote:
> > I reworked the patch slightly.
>
> This small cleanup makes sense to me since do_analyze_rel() already
> looks at if VACOPT_VERBOSE is set meaning related code is grouped closer
> after this small refactoring.
>
> The patch no longer applied so I rebased it.

Sorry, but -1 from me because this change would lead to doing the same
setup repeatedly when analyzing inheritance trees, which is not great.

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.
Next
From: Tomas Vondra
Date:
Subject: Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE