Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit
Date
Msg-id CAPmGK143p8iMbnZjwRcD5m9efwe5UHQT9rWEZPaGkoP5o4FjOg@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit
List pgsql-hackers
On Fri, May 6, 2022 at 7:08 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > > On Wed, Apr 20, 2022 at 4:55 AM David Zhang <david.zhang@highgo.ca> wrote:
> > >> +     * remote server in parallel at (sub)transaction end.

> I noticed that the comment failed to mention that the
> parallel_commit option is disabled by default.  Also, I noticed a
> comment above it:
>
>      * It's enough to determine this only when making new connection because
>      * all the connections to the foreign server whose keep_connections option
>      * is changed will be closed and re-made later.
>
> This would apply to the parallel_commit option as well.  How about
> updating these like the attached?  (I simplified the latter comment
> and moved it to a more appropriate place.)

I’m planning to commit this as a follow-up patch for commit 04e706d42.

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw "parallel_commit" docs
Next
From: Amit Kapila
Date:
Subject: Re: Logical replication timeout problem